Set the default capstone version to v5 instead of v4 #345
Closed
yossizap wants to merge 5 commits intorizinorg:devfrom
Closed
Set the default capstone version to v5 instead of v4 #345yossizap wants to merge 5 commits intorizinorg:devfrom
yossizap wants to merge 5 commits intorizinorg:devfrom
Conversation
yossizap
requested review from
XVilka,
kazarmy,
ret2libc,
thestr4ng3r and
wargio
as code owners
Member
|
BTW, some code uses |
ITAYC0HEN
approved these changes
Jan 12, 2021
Member
|
TBH, it looks like capstone v5 has some wrong output. |
ret2libc
requested changes
Jan 18, 2021
Member
ret2libc
left a comment
ret2libc
left a comment
There was a problem hiding this comment.
As previously said (here on mattermost, don't remember) you probably have to change analysis_riscv_cs.cto not use CSNEXT but check the CS_API_* defines as done elsewhere.
Member
|
Could you please rebase this one? There are conflicts need to be resolved. |
Member
|
We should also update the subproject wraps since now the project moved to https://github.com/capstone-engine/capstone |
Member
|
@yossizap could you please rebase and solve the conflicts? Then we could see what is broken |
Member
|
Closed in favor of #3301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
v5 isn't going to be released officially anytime soon and there are new instructions like Intel's CET that aren't supported in v4. As long as the tests pass I don't see a reason not to do update.
Test plan
See that tests are green